Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Route into folders instead of parents in private links #5654

Merged
merged 2 commits into from
Mar 9, 2022
Merged

Route into folders instead of parents in private links #5654

merged 2 commits into from
Mar 9, 2022

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Aug 10, 2021

Description

For private links to a folder: route directly into the folder instead of the parent. Routing to parent is only valid for files.

Related Issue

Motivation and Context

How Has This Been Tested?

  • CI

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • write changelog item

@update-docs
Copy link

update-docs bot commented Aug 10, 2021

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@sonarcloud
Copy link

sonarcloud bot commented Aug 10, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link
Contributor

Results for oC10Basic https://drone.owncloud.com/owncloud/web/18135/7/1
💥 The acceptance tests pipeline failed. The build has been cancelled.

@pascalwengerter
Copy link
Contributor

@kulmann what was missing to merge this one? :)

@kulmann
Copy link
Member Author

kulmann commented Nov 8, 2021

There was an issue with the sdk not throwing errors but instead returning an error-like string. Needs to be fixed and then updated in web (e.g. in this PR). Well, and then, getting CI green. ;-)

@kulmann kulmann force-pushed the fix-resolving-private-link branch from 1aacf04 to 445d420 Compare March 9, 2022 10:27
@kulmann kulmann marked this pull request as ready for review March 9, 2022 10:27
@kulmann
Copy link
Member Author

kulmann commented Mar 9, 2022

Rebased and also used the chance to fix a bug when resolving private links. The issue in the sdk was resolved so this is ready for review now. @pascalwengerter could you take a look?

@kulmann kulmann force-pushed the fix-resolving-private-link branch from 445d420 to 29d17e2 Compare March 9, 2022 10:29
@kulmann kulmann self-assigned this Mar 9, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 9, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

50.0% 50.0% Coverage
0.0% 0.0% Duplication

pascalwengerter
pascalwengerter approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😍 finally

@kulmann kulmann merged commit a97583c into master Mar 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix-resolving-private-link branch March 9, 2022 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@fschade fschade Awaiting requested review from fschade

Assignees

@kulmann kulmann

Labels
None yet
Projects
No open projects
Web Support Board
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] private link to folder opens parent folder
3 participants
@kulmann @ownclouders @pascalwengerter